Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source for google_gke_hub_membership_binding #11032

Open
wants to merge 71 commits into
base: main
Choose a base branch
from

Conversation

sahsagar-google
Copy link
Member

@sahsagar-google sahsagar-google commented Jun 24, 2024

Fixes hashicorp/terraform-provider-google#18538

Release Note Template for Downstream PRs (will be copied)

`google_gke_hub_membership_binding`

sahsagar-google and others added 30 commits July 19, 2023 19:04
sahsagar-google and others added 23 commits October 23, 2023 15:25
…ce state. Adding membership_location field to the doc
…end needs a resource in case of deletion update for that field
@github-actions github-actions bot requested a review from shuyama1 June 24, 2024 23:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 165 insertions(+))
google-beta provider: Diff ( 3 files changed, 165 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 13
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGKEHub2MembershipBinding_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test


func testAccDataSourceGoogleGKEHub2MembershipBinding_basic(context map[string]interface{}) string {
return acctest.Nprintf(`
resource "google_project" "project" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason that we need a new project created for this test? I check the test for the resource google_gke_hub_membership_binding and I don't see project creation is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me remove the project creation, will update you. Thank you for your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants