-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source for google_gke_hub_membership_binding #11032
base: main
Are you sure you want to change the base?
Conversation
…hings simpler in the review
…h the one from test env
…ce state. Adding membership_location field to the doc
…d of under the oci field
…1beta1 will be deprecated soon
…end needs a resource in case of deletion update for that field
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 27 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
|
||
func testAccDataSourceGoogleGKEHub2MembershipBinding_basic(context map[string]interface{}) string { | ||
return acctest.Nprintf(` | ||
resource "google_project" "project" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason that we need a new project created for this test? I check the test for the resource google_gke_hub_membership_binding
and I don't see project creation is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me remove the project creation, will update you. Thank you for your comment.
Fixes hashicorp/terraform-provider-google#18538
Release Note Template for Downstream PRs (will be copied)