Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Lake Formation Resource Permission parameters need to be Lexical order #31096

Open
whatnick opened this issue May 2, 2023 · 1 comment · May be fixed by #38047
Open

[Bug]: Lake Formation Resource Permission parameters need to be Lexical order #31096

whatnick opened this issue May 2, 2023 · 1 comment · May be fixed by #38047
Labels
bug Addresses a defect in current functionality. service/lakeformation Issues and PRs that pertain to the lakeformation service.

Comments

@whatnick
Copy link

whatnick commented May 2, 2023

Terraform Core Version

1.3.6

AWS Provider Version

4.64.0

Affected Resource(s)

  • aws_lakeformation_permissions

Expected Behavior

The following code block should not lead to deletion/creation of resources if unchanged.

resource "aws_lakeformation_permissions" "lf_read" {
    permissions = ["SELECT", "DESCRIBE"]
    for_each = data.aws_iam_role.some_roles
    principal = each.value.arn
    table {
        database_name = var.glue_database
        wildcard = true
    }
}

Actual Behavior

The above code block leads to deletion and creation of the lake formation permission on multiple runs due to internal/implicit reordering in the provider to lexical order.
image

Changing the source in Terraform for permissions to be lexical order stops this unexpected behaviour.

resource "aws_lakeformation_permissions" "lf_read" {
    permissions = ["DESCRIBE", "SELECT"]
    for_each = data.aws_iam_role.some_roles
    principal = each.value.arn
    table {
        database_name = var.glue_database
        wildcard = true
    }
}

Relevant Error/Panic Output Snippet

N/A

Terraform Configuration Files

N/A

Steps to Reproduce

N/A

Debug Output

N/A

Panic Output

N/A

Important Factoids

The documentation hints towards implicit lexical ordering. This helped with troubleshooting this issue. Happy to document this in the provider explicitly.

Valid values may include ALL, ALTER, ASSOCIATE, CREATE_DATABASE, CREATE_TABLE, DATA_LOCATION_ACCESS, DELETE, DESCRIBE, DROP, INSERT, and SELECT

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lakeformation_permissions

Would you like to implement a fix?

Yes

@whatnick whatnick added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/lakeformation Issues and PRs that pertain to the lakeformation service.
Projects
None yet
2 participants