Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert "Search" to use SQLite Full-Text-Search instead of pattern matching #29

Open
haroldadmin opened this issue Sep 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@haroldadmin
Copy link
Owner

The current search implementation uses the LIKE operator to compare launches, launchpads, and rockets against the given query. This is okay, but a better implementation would use Room's FTS support for this.

Required tasks:

  • Create FTS tables to index launches, rockets and launchpads
  • Add a DB creation callback to rebuild FTS indices in onCreate() method of the RoomDatabase.Callback class
  • Refactor Search's ViewModel to use these FTS tables for searching

Bonus tasks:

  • Use a custom ranking function to order results by their relevance with the help of matchinfo
@haroldadmin haroldadmin added enhancement New feature or request Hacktoberfest Good issues for new contributors to the repository labels Sep 27, 2020
@haroldadmin haroldadmin removed the Hacktoberfest Good issues for new contributors to the repository label Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant