Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For Graceful Shutdown #663

Open
aryanmehrotra opened this issue May 28, 2024 · 2 comments · May be fixed by #673
Open

Support For Graceful Shutdown #663

aryanmehrotra opened this issue May 28, 2024 · 2 comments · May be fixed by #673
Labels
enhancement New feature or request

Comments

@aryanmehrotra
Copy link
Contributor

Application should wait before all the goroutines are completed before shutting down application

@vipul-rawat vipul-rawat added the enhancement New feature or request label May 28, 2024
@ccoVeille
Copy link
Contributor

I second that, but I would say the app should wait a short delay and not forever. Something like 5s-1m depending on the app. So it could be an app parameter

@vikash
Copy link
Contributor

vikash commented May 29, 2024

Agreed. 5 second is a respectable default - with an option to override it, if user so wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants