Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brn and Hlm Error Directive for Form Fields #294

Open
1 of 2 tasks
thatsamsonkid opened this issue May 25, 2024 · 1 comment · May be fixed by #320
Open
1 of 2 tasks

Brn and Hlm Error Directive for Form Fields #294

thatsamsonkid opened this issue May 25, 2024 · 1 comment · May be fixed by #320
Assignees
@thatsamsonkid
Labels
enhancement New feature or request

Comments

@thatsamsonkid
Copy link
Collaborator

Which scope/s are relevant/related to the feature request?

Don't know / other

Information

Error messages for form controls currently need to be handled by user instead of having a directive similar to mat-error to handle showing and hiding the error message to the user and maintaining the style consistent with Shadcn

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@thatsamsonkid thatsamsonkid added the enhancement New feature or request label May 25, 2024
@thatsamsonkid thatsamsonkid self-assigned this Jun 11, 2024
@cjosue15
Copy link

Hi, this is my first time trying to contribute to open source, I think I have a solution to implement the same angular material functionality, but with shadcn style, so I would like to submit my PR.

form-field.mov

cjosue15 added a commit to cjosue15/spartan that referenced this issue Jun 29, 2024
@cjosue15
feat(form-field): add new component and directives (goetzrobin#294)
d814deb 
- feat(hlm-error): new directive to handle error

- feat(hlm-hint): new directive to handle extra info

- feat(error-state): add service to show error depends on the dirty or touched state
cjosue15 added a commit to cjosue15/spartan that referenced this issue Jun 29, 2024
@cjosue15
refactor(form-field): create brain form field control (goetzrobin#294)
d5edc12 
- move the control to another package to avoid Nx Circular Dependency
@cjosue15 cjosue15 linked a pull request Jun 29, 2024 that will close this issue
Open
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatsamsonkid thatsamsonkid

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(form-field) create new component to handle errors and hints cjosue15/spartan
2 participants
@thatsamsonkid @cjosue15