Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select: ability to specify trigger template with any selector (not just hlm) #193

Open
1 of 2 tasks
alexciesielski opened this issue Mar 6, 2024 · 0 comments
Open
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@alexciesielski
Copy link
Contributor

Which scope/s are relevant/related to the feature request?

select

Information

As already mentioned in Discord I rename all hlm selectors to my customer's prefixes, so the final HTML is consistent, in that all component use the customer's prefix.

Unfortunately there is a dependency of brn-select on hlm in the sense that the ng-content selects for a hlm-select-trigger, which means that it is not compatible with renamed triggers.

I'm pretty sure I am not the only one who will have the idea to fully customize the generated hlm content in their repository (I thought that's the whole point of being fully in charge of the final component logic), so my suggestions are:

  1. never depend/reference anything from hlm inside brn
  2. instead of using ng-content using @ContentChild that the consumers provide (solution as shown in Discord)

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@alexciesielski alexciesielski added the enhancement New feature or request label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant