Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --since-commit to --commits #267

Open
tarkatronic opened this issue Nov 4, 2021 · 1 comment
Open

Change --since-commit to --commits #267

tarkatronic opened this issue Nov 4, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tarkatronic
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

The current --since-commit option is not the most intuitive, and does not always work as expected.

Describe the solution you'd like

Instead of the current --since-commit, we should allow git-style refs/range of refs to be specified. This will make much more sense to common git users, and will be far more flexible.

A user could then specify:

  • --commits asdf1234..HEAD which would be the same as --since-commit asdf1234
  • --commits asdf1234..qwer0987 to inspect a distinct range of commits, which is net new functionality
  • --commits HEAD~5..HEAD which would be the same as --max-depth=5
@tarkatronic tarkatronic added the enhancement New feature or request label Nov 4, 2021
@tarkatronic tarkatronic self-assigned this Nov 9, 2021
@tarkatronic tarkatronic modified the milestone: Version 3.0 Nov 9, 2021
@tarkatronic tarkatronic removed their assignment Nov 11, 2021
@tarkatronic tarkatronic added the help wanted Extra attention is needed label Nov 11, 2021
@connorjburton
Copy link

+1 to this, we were using --since-commit in 2.x in our Jenkins pipelines as Jenkins provided us the last successful commit to be built, so we were only scanning the commits that hadn't been successfully built before.

--commits would give us the same functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants