You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Joins/InnerJoins, there is an inconsistency about how the join clause is processed.
My application uses a number of preprepared filters, including some generated dynamically.
When used as Scopes() for normal queries, they work fine, but when they are used as a clause in a Join() or InnerJoin() they are ignored
db.Find(&User{})
SELECT*FROM`users`WHERE`users`.`deleted_at` IS NULL
db.Joins("Group").Find(&User{})
SELECT`users`.`id`,
`users`.`created_at`,
`users`.`updated_at`,
`users`.`deleted_at`,
`users`.`name`,
`users`.`group_id`,
`Group`.`id`AS`Group__id`,
`Group`.`created_at`AS`Group__created_at`,
`Group`.`updated_at`AS`Group__updated_at`,
`Group`.`deleted_at`AS`Group__deleted_at`,
`Group`.`name`AS`Group__name`FROM`users`LEFT JOIN`groups``Group`ON`users`.`group_id`=`Group`.`id`AND`Group`.`deleted_at` IS NULLWHERE`users`.`deleted_at` IS NULL
In this case the parameter is checked, and isnt a simple "Where" clause, so it is ignored.
SELECT`users`.`id`,
`users`.`created_at`,
`users`.`updated_at`,
`users`.`deleted_at`,
`users`.`name`,
`users`.`group_id`,
`Group`.`id`AS`Group__id`,
`Group`.`created_at`AS`Group__created_at`,
`Group`.`updated_at`AS`Group__updated_at`,
`Group`.`deleted_at`AS`Group__deleted_at`,
`Group`.`name`AS`Group__name`FROM`users`LEFT JOIN`groups``Group`ON`users`.`group_id`=`Group`.`id`AND`Group`.`deleted_at` IS NULLWHERE`users`.`deleted_at` IS NULL
If "chainable_api.go" included a call to db.executeScopes() before checking
if where, ok := db.Statement.Clauses["WHERE"].Expression.(clause.Where); ok {
j.On = &where
}
This would work.
(Ps, I'm new to gorm playground, and I couldn't get past the gorm.io/gen/examples/dal: cannot find module providing package gorm.io/gen/examples/dal error)
The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.io ✨ Search Before Asking ✨
Playground Pull Request Link
go-gorm/playground#743
Description
When using Joins/InnerJoins, there is an inconsistency about how the join clause is processed.
My application uses a number of preprepared filters, including some generated dynamically.
When used as Scopes() for normal queries, they work fine, but when they are used as a clause in a Join() or InnerJoin() they are ignored
Note the "AND Group.id = 2" - this is as expected.
In this case the parameter is checked, and isnt a simple "Where" clause, so it is ignored.
If "chainable_api.go" included a call to
db.executeScopes()
before checkingThis would work.
(Ps, I'm new to gorm playground, and I couldn't get past the
gorm.io/gen/examples/dal: cannot find module providing package gorm.io/gen/examples/dal
error)Go playground test output
Sample Code
Edit: formatting
The text was updated successfully, but these errors were encountered: