Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate CommandEncoder on invalid commands #5854

Open
sagudev opened this issue Jun 21, 2024 · 1 comment
Open

Invalidate CommandEncoder on invalid commands #5854

sagudev opened this issue Jun 21, 2024 · 1 comment

Comments

@sagudev
Copy link
Contributor

sagudev commented Jun 21, 2024

Is your feature request related to a problem? Please describe.
Spec says that we should invalidate GPUCommandEncoder on invalid usage (see copybuffertobuffer for example). Currently error is just returned without invalidating command encoder.

Describe the solution you'd like
command_encoder_copy_buffer_to_buffer and others should also invalidate command encoder to match the spec.

Describe alternatives you've considered
Do nothing (this might be feature not a bug).

@cwfitzgerald
Copy link
Member

We should ideally make this process automatic when an error is returned so this action isn't forgotton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants