Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank versions of wgpu without #5812? #5837

Open
workingjubilee opened this issue Jun 18, 2024 · 3 comments
Open

Yank versions of wgpu without #5812? #5837

workingjubilee opened this issue Jun 18, 2024 · 3 comments

Comments

@workingjubilee
Copy link
Contributor

Before d309bba, Direct3D was just merrily reading random uninit data into its execution. We know this for a fact because the very moment wgpu called a version of compile_fxc compiled by a rustc with rust-lang/rust@38104f3 on Windows, the programs got hoist on the petard of STATUS_ACCESS_VIOLATION. Much better, because the bug was made visible and has been quickly fixed! It is worth considering yanking affected versions of wgpu, especially those that have the fix backported to their major version, so that Windows stops munching on garbage data, and to accelerate retiring the affected versions from the ecosystem (even if it does not actually completely remove them due to how yanking works).

...Or not! I'm a programmer, not a cop.

@ErichDonGubler
Copy link
Member

ErichDonGubler commented Jun 20, 2024

Adding this to our wgpu maintainers meeting agenda for next Wednesday.

@jimblandy
Copy link
Member

Which versions are affected?

@workingjubilee
Copy link
Contributor Author

This goes back to the introduction of 81569dd sooo wgpu 0.15.0 it seems?

That is a... lot of versions to yank, so I think it would be most productive to, e.g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants