Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXC requires ASCII HLSL code #5814

Open
teoxoy opened this issue Jun 14, 2024 · 0 comments
Open

FXC requires ASCII HLSL code #5814

teoxoy opened this issue Jun 14, 2024 · 0 comments
Labels
api: dx12 Issues with DX12 or DXGI area: correctness We're behaving incorrectly naga Shader Translator type: bug Something isn't working

Comments

@teoxoy
Copy link
Member

teoxoy commented Jun 14, 2024

pSourceName, pEntrypoint should also be ASCII.

See #5812 (comment) for all the details.

This needs work in naga to remap all non-ASCII identifiers to ASCII.
@teoxoy teoxoy added type: bug Something isn't working area: correctness We're behaving incorrectly api: dx12 Issues with DX12 or DXGI naga Shader Translator labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: dx12 Issues with DX12 or DXGI area: correctness We're behaving incorrectly naga Shader Translator type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teoxoy