Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fuzzy search #115

Open
akriese opened this issue Jan 4, 2023 · 4 comments
Open

Implement fuzzy search #115

akriese opened this issue Jan 4, 2023 · 4 comments

Comments

@akriese
Copy link
Contributor

akriese commented Jan 4, 2023

I am using pass on mutliple different systems and in different browsers. A thing that I am currently missing in pass-winmenu compared to other plugins/GUIs is fuzzy searching my URLs. I want to be able to effectively filter my collection by selected substrings that I know are in the desired password path/url.
Could something like FuzzySharp be leveraged to make fuzzy finding possible without much effort? Glad to hear about what you think about this suggestion :)

@geluk
Copy link
Owner

geluk commented Jan 11, 2023

I definitely think the search functionality could be better. You can search for multiple substrings by separating them with a space, but there is no fuzzy search, abbreviation search, etc.

It hasn't really been a priority for me since the way it works right now is fine for me, but it is definitely possible to improve this. Unfortunately it looks like FuzzySharp has not seen updates in the past 2.5 years, so I'm hesitant about adding it as a dependency, but depending on what search features you're interested in, it may not be too difficult to add those manually. Are there any specific features you'd like to see?

@akriese
Copy link
Contributor Author

akriese commented Jan 29, 2023

I didn't know about using space. That definitely helps already! In case I ever feel the need for fuzzy search, I'll come back to this issue. You can close this if nobody else is interested in this feature.

@akriese
Copy link
Contributor Author

akriese commented Jan 29, 2023

Also, how about mentioning the usage in the Usage section of the readme?

Something like (addition in italic):

Usage

Bring up the password menu with the keyboard shortcut Ctrl Alt P. The password menu allows you to quickly search through your passwords to find the one you are looking for. Navigate through the results by pressing Tab, and press Enter to decrypt the selected password. Use spaces between words to search for multiple substrings of the password path to filter more efficiently.

@willpower232
Copy link

why not open a PR ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants