-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: trailing backslash removed in Dockerfile #304
Comments
Hi My environment: |
This issue is a duplicate of #176 which links to The issue is that the plugin is using
is valid but in docker it breaks since the line is broken. In my case I use
so that the shell scripts have all the operators on the next line and this happens to be aligned with the dockerfiles as well. |
Is this fixed already? |
Still experiencing this bug. It also seems disabling formatting for Dockerfiles doesn't work: "[docker]": {
"editor.formatOnSave": false,
"editor.defaultFormatter": null
},
"[dockerfile]": {
"editor.formatOnSave": false,
"editor.defaultFormatter": null
}, |
"[dockerfile]": {
"editor.formatOnSave": false,
}, This actually worked for me, if you also add: "shellformat.effectLanguages": [
"shellscript",
// "dockerfile", // Remove me!!
"dotenv",
"hosts",
"jvmoptions",
"ignore",
"gitignore",
"properties",
"spring-boot-properties",
"azcli",
"bats"
], Thank you @Octogonapus ! |
The shfmt crew says explicitly that dockerfile is not supported. It seems like we should perhaps prune Dockerfile support out of this extension? |
Type: Bug
Before formatting:
After formatting:
Notice first backslash is removed, this breaks the functionality of the file.
The text was updated successfully, but these errors were encountered: