Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Move FirebaseAppCheckInterop to interop-ios-for-google-sdks repo #13060

Open
andrewheard opened this issue Jun 4, 2024 · 0 comments · May be fixed by #13123
Open

[FR]: Move FirebaseAppCheckInterop to interop-ios-for-google-sdks repo #13060

andrewheard opened this issue Jun 4, 2024 · 0 comments · May be fixed by #13123
Assignees

Comments

@andrewheard
Copy link
Contributor

Description

To allow FirebaseAppCheckInterop to be used as a dependency in other Google SDKs outside the firebase-ios-sdk repo it would need to be added as a library product in Swift Package Manager. However, we should not add it to Package.swift in this repo since it's not intended for use by 3P developers. We should:

  1. Move https://github.com/firebase/firebase-ios-sdk/tree/main/FirebaseAppCheck/Interop to https://github.com/google/interop-ios-for-google-sdks.
  2. Add a FirebaseAppCheckInterop product to https://github.com/google/interop-ios-for-google-sdks/blob/main/Package.swift.
  3. Update the lower range of
    .package(
    url: "https://github.com/google/interop-ios-for-google-sdks.git",
    "100.0.0" ..< "101.0.0"
    ),
    to the minimum version of interop-ios-for-google-sdks containing FirebaseAppCheckInterop.

API Proposal

No response

Firebase Product(s)

App Check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant