Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive/accent insensitive comparisons #38

Open
phatcher opened this issue Apr 30, 2024 · 1 comment
Open

Case insensitive/accent insensitive comparisons #38

phatcher opened this issue Apr 30, 2024 · 1 comment

Comments

@phatcher
Copy link

Is there anyway of doing case/accent insensitive comparisons without pre-processing the strings?

@paulirwin
Copy link
Member

@phatcher There is not, currently. This library is a port of the Java library java-string-similarity, which does not support it either (AFAICT at least). While we have added some performance optimizations, we historically have tried to track the upstream project. So normally I would suggest opening an issue there, and once it supports it, we'll port the change here.

However, the upstream project hasn't had a release in 4 years now as it is very stable, so I am unsure of whether that would happen without someone actually contributing the PR. At some point we might consider diverging to add features like this, but I'd at least like to try to upstream it first to benefit the Java community as well, and only resort to diverging if we have to. If you have the Java chops to do this, it would be great to submit a PR there. I'd suggest opening an issue first though to make sure the author agrees with the reasoning.

If you wouldn't mind kicking that upstream, that would be awesome. Also include in that (and here) some examples of what behavior you'd expect. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants