feat(compiler): Handle TSSatisfiesExpression #29818
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: c2ae9e2...a4b0ec0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Still fighting with linter dependencies, converting to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #29754
Details
I tried keeping
@babel/typesas low as possible, to match the actual used implementation. However, there were multiple issues:SourceLocationseems to now have identifiers, filename andindex. It is used in scope merging. Since filename and identifier cannot be "merged", I chose therightlocation as the one supplying these, because the only usage of that function passesidentifierfor therightlocation. This might not be what we want, please check this and assume that I don't know what I am doing :)How did you test this change?
Added a test for a simple case. I think we don't need a more complex one, since we're only interested in the inner expression and not in the
satisfiesconstraint.