Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_XXXXX functions in grid_info should return bool #93

Open
eyalroz opened this issue Jun 14, 2021 · 0 comments
Open

is_XXXXX functions in grid_info should return bool #93

eyalroz opened this issue Jun 14, 2021 · 0 comments
Assignees
@eyalroz
Labels
bug Something isn't working fixed on development A fix for this issue has been committed to the development branch

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 14, 2021

Functions like is_first(), is_last() etc. in on_device/grid_info.cuh should return a boolean value, not an unsigned integer, which they currently do.
@eyalroz eyalroz added the bug Something isn't working label Jun 14, 2021
@eyalroz eyalroz self-assigned this Jun 14, 2021
eyalroz pushed a commit that referenced this issue Jun 14, 2021
Fixes #93: grid_info tweaks.
aae3a11 
* Return type of `is_` functions set to `bool`
* A few more aliases
@eyalroz eyalroz added the fixed on development A fix for this issue has been committed to the development branch label Jun 14, 2021
eyalroz pushed a commit that referenced this issue Jun 14, 2021
Fixes #93: grid_info tweaks.
4f10872 
* Return type of `is_` functions set to `bool`
* A few more aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug Something isn't working fixed on development A fix for this issue has been committed to the development branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz