[feat] 新增 find-task/apply/:taskId 幫手應徵功能 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix] findTaskDetails查無對應user帳號時，報錯40200
|
少了推播功能 |
erik1110
reviewed
May 19, 2023
controller/findTaskController.js
Outdated
| if (!task) { | ||
| return next(appError(400, '40212', '查無此任務')); | ||
| } | ||
| if (task.userId._id.toString() === userId) { |
| return next(appError(400, '40216', '無法應徵自己的任務')); | ||
| } | ||
| if (task.helpers.some((helper) => helper.helperId._id.toString() === userId)) { | ||
| return next(appError(400, '40217', '已應徵過此任務')); |
There was a problem hiding this comment.
剛剛試了一下 沒轉型的話，比對永遠是false
你那邊有沒有類似的id比對，我想參考確認一下
[fix] 幫手應徵任務後，要發送通知給雙方
Open
erik1110
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feat] 新增 find-task/apply/:taskId 幫手應徵功能
[fix] findTaskDetails查無對應user帳號時，報錯40200