Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make history xdg base directory specification compliant #158

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

make history xdg base directory specification compliant #158

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 24, 2020

fixes #157

@ghost
Copy link
Author

ghost commented Apr 24, 2020

I'm not sure why that fails on freebsd...

@JohnHolmesII
Copy link

FreeBSD has some macro magic going on with dirname
https://github.com/freebsd/freebsd/blob/release/12.1.0/include/libgen.h

If you want to use dirname, you will likely need to include a FreeBSD ifdef or something equivalent. The joy is overwhelming 😄

@ghost
Copy link
Author

ghost commented May 2, 2020 •
edited by ghost
Loading

how is this even failing, the log seems fine.
with the freebsd magic I at least had errors...

@emersion
Copy link
Owner

emersion commented May 2, 2020

Ah, don't worry about it. I'll patch the CI so that the annotator only runs for the master branch.

@ghost
Copy link
Author

ghost commented May 2, 2020

Well, at least it's not my fault this time then :D

omasanori
omasanori reviewed Nov 5, 2020
View reviewed changes
frontend/readline.c Outdated Show resolved Hide resolved
emersion
emersion requested changes Nov 11, 2020
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a PR, sorry for the long wait. Here are a few comments.

frontend/readline.c Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
frontend/readline.c Outdated Show resolved Hide resolved
@ghost ghost requested a review from emersion November 12, 2020 15:44
@emersion
Copy link
Owner

Reported the FreeBSD bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251270

@ghost
Copy link
Author

ghost commented May 27, 2021

Do you want to wait for FreeBSD to fix the linked bug or is there something else holding up this PR?

@emersion
Copy link
Owner

emersion commented Jun 3, 2021

Sorry, I won't have time to look into this in the near future.

illiliti
illiliti reviewed Jun 20, 2021
View reviewed changes
frontend/readline.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion Awaiting requested review from emersion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

History just gets placed in $HOME
5 participants
@JohnHolmesII @emersion @omasanori @eli-schwartz @illiliti