Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Release doc for v29.0.0 provides false info about feature availability #42377

Open
3 tasks done
Imperat opened this issue Jun 6, 2024 · 4 comments
Open
3 tasks done

Comments

@Imperat
Copy link
Contributor

Imperat commented Jun 6, 2024

Preflight Checklist

Electron Version

29.0.0

What operating system are you using?

Any

Operating System Version

Any

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

In the release doc for Electron 29.0.0 there is a statement:

  • Added WebContentsView and BaseWindow, replacing the now-deprecated BrowserView APIs. #40759

This feature was first merged here and backported to v 29.0.0 here. However, later this PR was reverted here only for v 29.0.0.

I expect WebContentsView and BaseWindow APIs are available in all 29-x-y versions

Actual Behavior

WebContentsView and BaseWindow are not available.

Testcase Gist URL

No response

Additional Information

No response

@Imperat
Copy link
Contributor Author

Imperat commented Jun 6, 2024

🙌 I do not propose getting this feature back. I mostly raised this to confirm that all Electron 29-x-y releases have the old implementation of BrowserView API

@codebytere
Copy link
Member

@Imperat you're correct, this should be removed from 29 notes!

@Imperat
Copy link
Contributor Author

Imperat commented Jun 6, 2024

Thank you very much for the confirmation @codebytere 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@codebytere @Imperat and others