Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create Environment] Fix Undeleted EBS Snapshots #2221

Open
romulets opened this issue May 21, 2024 · 0 comments
Open

[Create Environment] Fix Undeleted EBS Snapshots #2221

romulets opened this issue May 21, 2024 · 0 comments
Labels
bug Something isn't working Team:Cloud Security Cloud Security team related Vulnerability Management

Comments

@romulets
Copy link
Member

Based on the issue #8365, we found out that some environment creations were leaving undeleted EBS Snapshots behind.

The cases:

  • Failed creations
  • Environments with flag Cleanup resources after provision true
  • Environment is created successfully but everything Delete Environment is used before CNVM cycle is done.

We need to find a way to prevent undeleted EBS Snapshots (And delete current backlog).

Suggestions:

  • Implement grace shutdown in cloudbeat, which deletes even if a context cancel is signaled
  • On environment creation, "pass" a unique key as configuration to Cloudbeat, which then will be used to tag all the created snapshots. Then, on GH, once the environment is being cleaned up, delete the snapshots with the unique "deployment" identifier.
    • Note: Pass is between quotes because maybe there is a unique deployment id already available
@romulets romulets added bug Something isn't working Team:Cloud Security Cloud Security team related Vulnerability Management labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Cloud Security Cloud Security team related Vulnerability Management
Projects
None yet
Development

No branches or pull requests

1 participant