Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting conditions configuration in CSPM/KSPM #2144

Open
2 tasks
oren-zohar opened this issue Apr 18, 2024 · 2 comments · May be fixed by elastic/integrations#10298
Open
2 tasks

Supporting conditions configuration in CSPM/KSPM #2144

oren-zohar opened this issue Apr 18, 2024 · 2 comments · May be fixed by elastic/integrations#10298
Assignees
Labels
8.15 candidate Team:Cloud Security Cloud Security team related

Comments

@oren-zohar
Copy link
Collaborator

oren-zohar commented Apr 18, 2024

Motivation
Following a fearture request from @BenB196 #2128

Definition of done

  • Add the conditions vars into the integration manifest, as seen here, for all of our integrations.
  • Add conditions configuration under advanced options into our integration deployment page

Related tasks/epics

@kubasobon
Copy link
Member

@maxcold I have prepared a PR adding condition variable to our integration. However I'd like to understand how it's used and what remains to be done to fulfill the Definition of Done. Would you be so kind and find time to chat with me about it?

@maxcold
Copy link
Contributor

maxcold commented Jun 28, 2024

From the cloudbeat side, will providing this variable work out of the box?

From the UX side as we have our custom integration design, I guess we need to involve product and design to find the proper place for such settings. In the default "Add integration" design there is a specific section "Settings" where user can change the settings per input (defined as vars in the manifest). We have a custom design for each var, therefore we will need to design and implement the conditions consistently across the inputs we support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.15 candidate Team:Cloud Security Cloud Security team related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants