Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Key support on Windows #56

Open
vbabiy opened this issue Mar 2, 2023 · 14 comments
Open

Media Key support on Windows #56

vbabiy opened this issue Mar 2, 2023 · 14 comments
Labels
enhancement New feature or request help wanted Extra attention is needed os:windows

Comments

@vbabiy
Copy link

vbabiy commented Mar 2, 2023

Are you planning on adding media key support?

@dweymouth
Copy link
Owner

dweymouth commented Mar 2, 2023

Edit 10/21/23: repurposing this issue for Windows media key integration since that's the last platform left

Media key support will need to be implemented using the media APIs of each platform. Tracking the completion of each platorm here:


Old invalid info, for historical context

Yes, I definitely would like to add media key support. There is no builtin API in the Fyne toolkit that this project is using for this, however. So I will either A) need to add a media key API to my Fyne fork, or B) find another 3rd party package that can provide media key events. If anyone knows of a 3rd party Go package for media keys, or how to scan for media key events in GLFW (so I can add it to the Fyne fork), please let me know!

@dweymouth dweymouth added enhancement New feature or request help wanted Extra attention is needed labels Mar 2, 2023
@dweymouth dweymouth pinned this issue Mar 3, 2023
@sentriz
Copy link

sentriz commented Mar 6, 2023

i think you need MPRIS https://wiki.archlinux.org/title/MPRIS

at least on linux

@dweymouth
Copy link
Owner

Related: #75

@dusnm dusnm mentioned this issue Apr 18, 2023
@dusnm
Copy link
Contributor

dusnm commented Apr 18, 2023

This is heavily platform dependent. Unix-like systems that implement free desktop standards like D-Bus (this would exclude MacOS) handle media keys through MPRIS. This also provides media controls for desktop environments like Gnome.

I doubt there is a clean way to make this feature cross-platform without implementing a solution for each platform separately.

@dweymouth dweymouth unpinned this issue Jul 15, 2023
@vbabiy
Copy link
Author

vbabiy commented Jul 26, 2023

MPRIS working great on linux (arch).

Great work!

@bvarick
Copy link

bvarick commented Aug 4, 2023

I'm struggling to get the media keys to work on Linux with a flatpak install. I think the permissions are off, but I'm not sure. Its currently listed as owning "org.mpris.MediaPlayer2.Supersonic". I think the ID is "dweymouth.supersonic", so maybe it should match?

@dweymouth
Copy link
Owner

I'm struggling to get the media keys to work on Linux with a flatpak install. I think the permissions are off, but I'm not sure. Its currently listed as owning "org.mpris.MediaPlayer2.Supersonic". I think the ID is "dweymouth.supersonic", so maybe it should match?

You may need to force-update the Flatpak. There was a recently fixed issue with Flatpak MPRIS permissions and the Flatpak manifest was updated but the app version number has not been bumped. See #226

@bvarick
Copy link

bvarick commented Aug 6, 2023

You may need to force-update the Flatpak. There was a recently fixed issue with Flatpak MPRIS permissions and the Flatpak manifest was updated but the app version number has not been bumped. See #226

That worked great, thanks!

@dweymouth dweymouth changed the title Media Key support Media Key support on Windows Oct 21, 2023
@selexin
Copy link

selexin commented Nov 15, 2023

Hey, how's progress going on the Windows Media Key support? Reckon we might see it in 0.90? 🙏

Love your work @dweymouth

@dweymouth
Copy link
Owner

Maybe.. definitely if you know anyone who knows WinAPI C/C++ development and can refer them over here :) Mac media key support was contributed by someone familiar with MacOS dev

@dweymouth
Copy link
Owner

Did a little more digging, and it seems like it may be difficult to get this working on Windows. See this issue here for discussion - but it seems the SystemMediaTransportControls APIs are a bit problematic to use for non-UWP apps, and especially apps built with a cross platform toolkit that never exposes a HWND directly.

@selexin
Copy link

selexin commented Jan 31, 2024

Thanks for the update @dweymouth fingers crossed they eventually make it easier to include windows media key integration. Still loving Supersonic.

@dweymouth
Copy link
Owner

Hmm, it seems like we could adapt Tauon Music Box's idea to access these APIs: Taiko2k/Tauon@6742576#diff-6b63f857d89b9e3a0dbd1cc014f89df23bf20d881fa07638c382044f6c73bf08

They compile a DLL that creates a dummy hidden application window so it can have access to those APIs. Maybe someone with more Win32 dev experience could give this approach a try

@nchietala
Copy link

For those of us on windows this AutoHotKey script will enable play/pause functionality while we wait for an update:

Media_Play_Pause::
    WinGet, targetWindow, ID, ahk_exe Supersonic.exe
    
    if (targetWindow) {
        ControlSend,, {Space}, ahk_id %targetWindow%
    }
    else {
        Run, "C:\Program Files\SuperSonic\Supersonic.exe"
        WinWait, ahk_exe Supersonic.exe,, 10
        WinGet, TargetWindow, ID, ahk_exe Supersonic.exe

        if (TargetWindow) {
            ControlSend,, {Space}, ahk_id %TargetWindow%

            WinClose, ahk_id %TargetWindow%
            ; WinMinimize, ahk_id %TargetWindow%
            ; This assumes that you've set your window to close to the system tray, move the comment ";" to the WinClose line if that is not the case.
        }
    }
return

@dweymouth dweymouth pinned this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed os:windows
Projects
None yet
Development

No branches or pull requests

7 participants