Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding instances with dstack apply #1327

Open
r4victor opened this issue Jun 12, 2024 · 3 comments
Open

Support adding instances with dstack apply #1327

r4victor opened this issue Jun 12, 2024 · 3 comments
Labels

Comments

@r4victor
Copy link
Collaborator

The proposal is to allow adding instances to pools via dstack apply as a replacement for dstack pool add and dstack pool add-ssh. The instance configurations could look like:

type: instance
name:
pool:
resources:
retry:
spot_policy:
max_price:
termination_policy:
termination_idle_time:
profile:
...other profile params
type: ssh-instance
name:
pool:
ssh_key_path:
region:
port:
user:
network:

The implementation will probably require refactoring to make use of instance configurations.

@peterschmidt85
Copy link
Contributor

type: instance or cluster? :)

@r4victor
Copy link
Collaborator Author

I'd start with instance since it's what dstack pool currently works with. We can discuss how dstack supposed to work with clusters in a separate issue: we could expand instance configuration to be able to provision multiple cluster nodes (may be as simple as specifying nodes: 8) or introducing a separate cluster configuration.

@peterschmidt85
Copy link
Contributor

I wouldn't rush and at least discuss this before implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants