Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping also considers record structs #74125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Escaping also considers record structs #74125

wants to merge 3 commits into from

Conversation

SteveDunn
Copy link

fix: #74117

Previously, record struct was not considered as needing to be escaped, so types like record struct @decimal would be represented as record struct decimal

@SteveDunn SteveDunn requested a review from a team as a code owner June 24, 2024 13:25
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 24, 2024
@SteveDunn
Copy link
Author

I'm not sure if those failures are related to my change, but anyone more familiar with them please correct me if I'm wrong.

@333fred
Copy link
Member

333fred commented Jun 26, 2024

@dotnet/roslyn-compiler for a second review.

@jaredpar jaredpar added this to the 17.12 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12
Development

Successfully merging this pull request may close these issues.

Symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat) does not escape everything it should
5 participants
@SteveDunn @333fred @CyrusNajmabadi @cston @jaredpar