Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new System.Numerics.Tensors library for DataFrame arithmetic operations (.net8) #7179

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

asmirnov82
Copy link
Contributor

Use new System.Numerics.Tensors library for DataFrame arithmetic operations (.net8)

Fixes #7178

The aim of this PR to use new library for DataFrame arithmetic operations instead of custom implemtation. At the same time provide backward compatibility for pre-.Net8.0 versions of the package. To achive this, all .,net version specific code is localised in nested private classes of static class Arithmetic that implements IArithmetic<T> interface and are not used directly by any other DataFrame classes

@asmirnov82 asmirnov82 changed the title Dataframe use numerics tensors Use new System.Numerics.Tensors library for DataFrame arithmetic operations (.net8) Jun 19, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (8e3f72d) to head (ee8bf16).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7179      +/-   ##
==========================================
- Coverage   68.67%   68.67%   -0.01%     
==========================================
  Files        1263     1263              
  Lines      257955   257955              
  Branches    26698    26698              
==========================================
- Hits       177148   177142       -6     
- Misses      73994    74000       +6     
  Partials     6813     6813              
Flag Coverage Δ
Debug 68.67% <0.00%> (-0.01%) ⬇️
production 62.93% <0.00%> (-0.01%) ⬇️
test 88.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ta.Analysis/Computations/Arithmetic.netstandard.cs 45.64% <ø> (ø)
....Analysis.Tests/DataFrameTests.BinaryOperations.cs 100.00% <ø> (ø)
...Microsoft.Data.Analysis/Computations/Arithmetic.cs 57.74% <0.00%> (-6.63%) ⬇️

... and 5 files with indirect coverage changes

@ericstj
Copy link
Member

ericstj commented Jun 24, 2024

cc @michaelgsharp @tannergooding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new System.Numerics.Tensors library for DataFrame arithmetic operations (.net8)
2 participants