Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic attributes #965

Open
5 tasks done
Happypig375 opened this issue Jan 21, 2021 · 2 comments · May be fixed by dotnet/fsharp#17258
Open
5 tasks done

Generic attributes #965

Happypig375 opened this issue Jan 21, 2021 · 2 comments · May be fixed by dotnet/fsharp#17258

Comments

@Happypig375
Copy link
Contributor

Generic attributes

Champion "Allow Generic Attributes" is currently in the C# team's working set.

Since CIL already supported this for a decade, if F# were to implement it, we won't have to wait for C# to have this.

Pros and Cons

The advantages of making this adjustment to F# are

  1. Enforcing generic restrictions at compile time which typeof cannot do
  2. Type-safe attribute members without type-unsafe boxing conversions with reflection
  3. Generics is faster than reflection

The disadvantages of making this adjustment to F# are (none)

Extra information

Estimated cost (XS, S, M, L, XL, XXL): M to L

Related suggestions: (put links to related suggestions here)

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

@jcmrva
Copy link

jcmrva commented May 5, 2022

Generic attributes are now in C# 11 preview.

I noticed it's possible to define them in F# (guessing the compiler doesn't know that inheriting Attribute makes it one):

type Foo<'t> () =
    inherit Attribute ()

I was a little surprised to find the above can be referenced in C# 11.

@dsyme
Copy link
Collaborator

dsyme commented Jun 14, 2022

I'll marked as approved-in-principle since this is in C# 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants