Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torches on the right-hand side of a corridor are too far from the wall #3290

Closed
AdamPlenty opened this issue Jun 4, 2024 · 3 comments · Fixed by dkfans/FXGraphics#63 · May be fixed by #3305
Closed

Torches on the right-hand side of a corridor are too far from the wall #3290

AdamPlenty opened this issue Jun 4, 2024 · 3 comments · Fixed by dkfans/FXGraphics#63 · May be fixed by #3305
Labels
Priority-Low Since-1997 Type-Defect

Comments

@AdamPlenty
Copy link
Contributor

image

image

Rotating the camera makes no difference, which means this is probably a rendering issue.
@AdamPlenty AdamPlenty changed the title Torches on the right of the screen are too far from the wall Torches on the right-hand side of a corridor are too far from the wall Jun 4, 2024
@AdamPlenty
Copy link
Contributor Author

Present since vanilla.

@AdamPlenty
Copy link
Contributor Author

Also affects possession:

image

image

@AdamPlenty
Copy link
Contributor Author

keeperfx/src/engine_render.c

Line 7779 in 354aa4c

if (((kspr_angle & 0x7FF) <= 1151) || ((kspr_angle & 0x7FF) >= 1919) || (creature_sprites->Rotable != 2) )

It seems the right-hand torches need an xflip, but are not getting one. If I force an xflip on everything, this glitch occurs the other way around.

@AdamPlenty AdamPlenty mentioned this issue Jun 14, 2024
Merged
AdamPlenty added a commit to AdamPlenty/keeperfx that referenced this issue Jun 14, 2024
@AdamPlenty
Repositioned torch flames
b96cae2 
Fixes dkfans#3290

See also dkfans/FXGraphics#63
@AdamPlenty AdamPlenty mentioned this issue Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority-Low Since-1997 Type-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Repositioned torches AdamPlenty/FXGraphics
Repositioned torch flames AdamPlenty/keeperfx
1 participant
@AdamPlenty