Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color::get_color(i32) should use u32 #141

Open
Omnislayer77 opened this issue Nov 20, 2022 · 2 comments
Open

Color::get_color(i32) should use u32 #141

Omnislayer77 opened this issue Nov 20, 2022 · 2 comments

Comments

@Omnislayer77
Copy link

The Color::get_color(i32) function should use a u32 because inputs such as 0xf44850ff which should give a color (r 0xf4, g 0x48, b 0x50, and a 0xff) are out of range of an i32, but would be suited by u32.

@DhwanishShah
Copy link

Hi, I want to work on this Issue. Can you please assign me this Issue? It's my college Assignment to work on the project on GitHub.

@DhwanishShah
Copy link

image

Let me know if the changes are supposed to be done in these files and I just need to change the i32 field to u32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants