Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately fetch after EXISTS response #3783

Open
1 of 3 tasks
Hocuri opened this issue Nov 28, 2022 · 2 comments · May be fixed by #4974
Open
1 of 3 tasks

Immediately fetch after EXISTS response #3783

Hocuri opened this issue Nov 28, 2022 · 2 comments · May be fixed by #4974

Comments

@Hocuri
Copy link
Collaborator

Hocuri commented Nov 28, 2022

Currently, after the server sends an EXISTS response, we do all kinds of things before we fetch the newly-arrived message. This leads to increased answer times.

We should:

  • remove the remaining jobs
  • move housekeeping to a separate loop
  • call store_seen_flags_on_imap() after fetching (currently we are calling it before)

#3240 was a draft PR that would have achieved the same goal in a different manner (and would have introduced new complexity).

@link2xt
Copy link
Collaborator

link2xt commented Nov 4, 2023

All the jobs have been removed, now they are explicitly called from inbox loop: #3457

@link2xt link2xt self-assigned this Nov 10, 2023
@link2xt link2xt linked a pull request Nov 10, 2023 that will close this issue
@link2xt
Copy link
Collaborator

link2xt commented Nov 10, 2023

I made a new PR which simply moves fetch directly after IDLE: #4974
Unlike old PR, new PR moves fetch call rather than doing fetch twice per iteration.

@link2xt link2xt removed their assignment Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants