Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add haystack-experimental dependency #7921

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add haystack-experimental dependency #7921

wants to merge 2 commits into from

Conversation

vblagoje
Copy link
Member

Adds haystack-experimental dependency so that users then don't need to manually install the experimental features via pip install haystack-experimental but instead automatically have them when they install Haystack.

@vblagoje vblagoje requested review from a team as code owners June 25, 2024 09:03
@vblagoje vblagoje requested review from dfokina and Amnah199 and removed request for a team June 25, 2024 09:03
@vblagoje vblagoje requested a review from shadeMe June 25, 2024 09:04
@vblagoje
Copy link
Member Author

cc @shadeMe @silvanocerza @julian-risch @anakin87 @davidsbatista
We can integrate this one now, correct? Anything else needs to be done beforehand?

@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9659581270

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.946%
Totals Coverage Status
Change from base Build 9615573436: 0.0%
Covered Lines: 6719
Relevant Lines: 7470
💛 - Coveralls

shadeMe
shadeMe approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. We just need to keep in mind that the if we don't have a haystack-experimental v0.1.0 release before haystack-ai==2.3.0, the installed dependency will just be a stub.

@vblagoje
Copy link
Member Author

Ok @shadeMe let's wait for initial haystack-experimental release and try everything out at that time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:build/distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the haystack-experimental package as a dependency
3 participants
@vblagoje @coveralls @shadeMe