Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: upgrade QuotaMgr to using protobuf #15009

Open
3 tasks
drmingdrmer opened this issue Mar 19, 2024 · 0 comments · May be fixed by #15858
Open
3 tasks

Refactor: upgrade QuotaMgr to using protobuf #15009

drmingdrmer opened this issue Mar 19, 2024 · 0 comments · May be fixed by #15858

Comments

@drmingdrmer
Copy link
Member

The problem

Currently QuotaMgr write json data into meta-service:
https://github.com/drmingdrmer/databend/blob/f248f211c9418e153d74515d0a755fbda11ef3ec/src/query/management/src/quota/quota_mgr.rs#L73

Json does not provide compatibility support as FromToProto does:
https://github.com/drmingdrmer/databend/blob/6332061fb2c8466c398b417cc6db878ba5933740/src/meta/proto-conv/src/from_to_protobuf.rs#L18

The setting data read/write should be upgrade to using FromToProto to provide well defined and tested backward compatibility.

TODO

  • keep the writing part unchanged, but read in pb/json compatible way.
  • upgrade to write pb data instead of json.
  • upgrade to read only pb format.
@forsaken628 forsaken628 linked a pull request Jun 21, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: upgrade QuotaMgr to using protobuf forsaken628/databend
1 participant
@drmingdrmer