Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Helm Chart version with the Dagger version + start tracking a changelog #7597

Open
gerhard opened this issue Jun 10, 2024 · 2 comments
Milestone

Comments

@gerhard
Copy link
Member

gerhard commented Jun 10, 2024

We did this with all SDKs in summer 2023:

We should do the same for the Helm chart (it's the only odd one out) and also start a changelog for it. As discussed here:

@gerhard gerhard added this to the v0.12.0 milestone Jun 10, 2024
@samalba samalba removed the area/ci label Jun 12, 2024
@pjmagee
Copy link
Contributor

pjmagee commented Jun 21, 2024

A Chart version is not the same as an Application version though, Charts can have the appVersion with a set default, like a dagger engine version. But if the chart is not actually changing on each release, does the chart version really have to align with the dagger cli version?

I see Chart versions as the structure of how you deploy dagger, not that it is also having to match the dagger product version. There could be many versions where nothing changes in the chart, but dagger has had many updates. This is also why I thought charts have the concept of Version of the Chart and appVersion, which can also be provided which is a sort of default for something like values.engine.tag.

Or do you mean to align the appVersion property?

You can see many examples of this on Artifact hub, in some cases, Chart versions are way higher than the Product version, because they improved the chart, and it had nothing to do with the Product itself as such.

@jedevc
Copy link
Member

jedevc commented Jun 25, 2024

Having separate version streams causes a few headaches from a releasing point-of-view.

Even without those head-aches, without the same versions in place, there's an assumption that you can mix-match engine and helm chart versions freely - you can use X engine and Y helm chart. While that might be the case for some helm charts, there's no guarantees that that would keep working - by having the same version number, it's made clearer that this is more required.

We currently don't release the helm chart separately at all - it's part of our release process for the entire engine, released in that same weekly/fortnightly cycle. One day, we might split those out, but if they're tied together, it makes sense to keep our versions tied IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants