Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mint is taking forever #21

Open
beta-ziliani opened this issue Mar 23, 2022 · 3 comments
Open

mint is taking forever #21

beta-ziliani opened this issue Mar 23, 2022 · 3 comments
Assignees

Comments

@beta-ziliani
Copy link
Member

No description provided.

@beta-ziliani
Copy link
Member Author

also crystal-db, although not sure they're related

@straight-shoota
Copy link
Member

straight-shoota commented Mar 23, 2022

In the mint test it seems that the ameba check hangs. It seems to be caused by the internal API change in the compiler, which should be fixed by crystal-ameba/ameba#259
Funny thing is that ameba still compiles. The compiler changes only break ameba's specs, which we also observed. But the ameba app itself builds but the binary is unusable (it seems to run an endless loop). This is because the breaking changes just affect equality checks with symbols, which do not cause a compile time error. So that's actually a good example why using symbols is bad and it's good that we've refactored that.
Ameba just needs to be updated to the new API.

@straight-shoota
Copy link
Member

straight-shoota commented Mar 23, 2022

The failing spec in crystal-db is unrelated. It's just expecting a specific error message from string to int conversion, but the format has changed in crystal-lang/crystal#11883. This needs to be fixed in crystal-db (crystal-lang/crystal-db#163).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants