Default Taxation Display Provider should respect Coreshop tax display setting

[benwalch]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no

DefaultTaxationDisplayProvider should respect CoreShop setting "display prices with tax" by default.

[dpfaffenbauer]

@benwalch what setting do you mean?

[benwalch]

@dpfaffenbauer see PR

[dpfaffenbauer]

I thought you mean that. But that is not a setting for the price display, it rather is a setting how the price is stored and calculated. Meaning that you could have a b2c site that uses net prices but still wants to display gross prices. Or a b2b site that stores gross prices but wants to show net prices

[benwalch]

i see. maybe an additional setting to control the displaying prices would be nice here.

[dpfaffenbauer]

Yes, maybe using CoreShop -> Settings?

[solverat]

I just came across this with the exact purpose, @dpfaffenbauer described: Client stores prices with tax (defined in store settings) but based on given parameters in context (b2b based on customer), he also wants to display prices without taxes.

That said, the service DefaultTaxationDisplayProvider is fine like it is. CoreShop can't resolve it for every project - just returning true is totally fine.

[dpfaffenbauer]

thanks for your feedback @solverat