Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate extension nav group to individual nav items #7763

Open
Tracked by #7762
deboer-tim opened this issue Jun 20, 2024 · 2 comments
Open
Tracked by #7762

Migrate extension nav group to individual nav items #7763

deboer-tim opened this issue Jun 20, 2024 · 2 comments
Assignees
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

In order to implement #6774 we need to replace both Kubernetes and Extensions navigation sections. Kubernetes is handled through #7759 but that's not a great default/don't need to wait to do extensions.

Describe the solution you'd like

Kubernetes will use #7759 to add a new nav group item (plus individual nav items). Although we could use the same mechanism we probably want each newly installed extension to appear in the main nav, so the recommendation is to just contribute them as individual nav items for now. If we want to add a 'extensions group' later it would be easy enough to add.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jun 20, 2024
@benoitf
Copy link
Collaborator

benoitf commented Jun 21, 2024

Before implementing anything globally, it needs to be validated by the implementation for extensions.

As if Kubernetes is moved to an extension, it should behave the same. And then I'm not sure it can behave in the same way depending on how it's implemented

@deboer-tim
Copy link
Collaborator Author

Aside from AI Lab (and possibly Kubernetes in the future), no other extension contributes more than one 'page'. I'd prefer to use #7759/#7761 to figure out if we keep the concept of nav groups and whether extensions can (easily) provide them, and use this issue to move single-page extensions 'out' of the nav section (and using the same registry as built-in pages) so that we could start supporting things like show/hide or handling too many items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants