Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upon mirror topic creation, have the option to not store credentials in the Terraform state file. #340

Open
AdamBartal opened this issue Jan 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@AdamBartal
Copy link

Just like with topic and schema creation, customer has asked if it could be possible to also have the option of NOT storing credentials in the TF state file when creating mirror topics.

Case 187643

Discussed in #terraform: https://confluent.slack.com/archives/C01880K2BAA/p1703872608176549?thread_ts=1703869169.969629&cid=C01880K2BAA

@AdamBartal AdamBartal added the enhancement New feature or request label Jan 2, 2024
@FireDrunk
Copy link

We've hit this issue as well. This has more effect on other parts of the code as well.

The issue lies within this code:
https://github.com/confluentinc/terraform-provider-confluent/blob/master/internal/provider/resource_kafka_mirror_topic.go#L95

It lacks the same logic as the regular topic:
https://github.com/confluentinc/terraform-provider-confluent/blob/master/internal/provider/resource_kafka_topic.go#L153

The regular topic attempts to extract the configuration from either the Environment or the Resource, whereas the Mirror topic specifically requires it to be set in the Resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants