Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a segfault when 'commit' or 'store_offsets' consumer method is called incorrectly with errored Message object #1754

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fixed a segfault when 'commit' or 'store_offsets' consumer method is called incorrectly with errored Message object #1754

merged 3 commits into from
Jun 28, 2024

Conversation

pranavrth
Copy link
Member

Fixes #1707

@pranavrth pranavrth requested a review from a team as a code owner May 27, 2024 18:41
anchitj
anchitj reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Though should we add a test for this?

@pranavrth pranavrth force-pushed the dev_segfault-commit-and-store-offset-message-with-error branch from 244e0e6 to f217ecb Compare June 26, 2024 12:29
@pranavrth pranavrth force-pushed the dev_segfault-commit-and-store-offset-message-with-error branch from f217ecb to 0854a86 Compare June 26, 2024 14:03
@pranavrth pranavrth requested a review from a team as a code owner June 26, 2024 14:03
anchitj
anchitj approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the chagnes

@pranavrth pranavrth merged commit a6d2e1e into master Jun 28, 2024
2 checks passed
@pranavrth pranavrth deleted the dev_segfault-commit-and-store-offset-message-with-error branch June 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anchitj anchitj anchitj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pranavrth @anchitj