We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint
run.skip-dirs
issues.exclude-dirs
We can see the following message running make lint in out plugin dirs with the latest golangci-lint:
make lint
WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.
This is not a priority for now, but should be outlined for the future.
The content you are editing has changed. Please copy your edits and refresh the page.
The text was updated successfully, but these errors were encountered:
Example line to update
cloudquery/cli/.golangci.yml
Line 4 in a10fb7f
Sorry, something went wrong.
chore: Replacing deprecated run.skip-dirs for issues.exclude-dirs in …
6a22399
…golanci.yml (#17916) #### Summary This PR resolve the issue #17455 => it removes the deprecated run.skipdir from .golangci.yml I used the documentation for golangci-lint here : https://golangci-lint.run/usage/configuration/#issues-configuration #### Changes there was only 2 .golangci.yml that needed changes (out of 4) : - the one in the cli folder - the one in the plugins folder (destination + source) I did not change theses 2 : - plugin-sdk did not have the run.skipdir directive. - codegen did not have any .golangci.yml file. #### Testing method I tested with golangci-lint before and after my modification : **Before**: ![before](https://github.com/cloudquery/cloudquery/assets/16516886/9b710643-d812-4753-a363-f61bb4f549cd) **After:** ![after](https://github.com/cloudquery/cloudquery/assets/16516886/aaa4e511-1129-44a2-a5a9-ea6d22ae33d8) This is my first contribution, I hope I did everything well, Have a good day
No branches or pull requests
We can see the following message running
make lint
in out plugin dirs with the latestgolangci-lint
:This is not a priority for now, but should be outlined for the future.
Tasks
The text was updated successfully, but these errors were encountered: