Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config file option for issues to ignore #32

Open
leanne73 opened this issue Apr 30, 2024 · 1 comment
Open

Add a config file option for issues to ignore #32

leanne73 opened this issue Apr 30, 2024 · 1 comment

Comments

@leanne73
Copy link
Contributor

It would be nice if you could specify CVEs to ignore via a config file, similar to bundler-audit's config file, instead of needing to append them each to the ruby-audit command using -i.

@mikesaelim
Copy link
Contributor

mikesaelim commented May 3, 2024

I can take this.

What should happen if someone specifies ignored CVEs through both the -i command line option and the config file? It looks like bundler-audit's logic says: if there are ignored CVEs specified through the -i command line option, then they override whatever is in the config file, instead of adding to it. I'm not so sure about this choice, but maybe it's best to follow the same convention so that users of both ruby_audit and bundler-audit aren't surprised?

Edit: Also, should we use the same default config filename, .bundler-audit.yml? And the same structure? I can see an argument for not wanting to tightly couple our config file to theirs, but I can also see an argument for not making users keep two config files in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants