Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][DX]: New EF refactor breaks static analysis of imports for IDEs #2398

Open
tazarov opened this issue Jun 21, 2024 · 4 comments · May be fixed by #2408
Open

[Bug][DX]: New EF refactor breaks static analysis of imports for IDEs #2398

tazarov opened this issue Jun 21, 2024 · 4 comments · May be fixed by #2408
Labels
bug Something isn't working

Comments

@tazarov
Copy link
Contributor

tazarov commented Jun 21, 2024 •
edited
Loading

What happened?

The new refactoring of the EFs with dynamic imports #2034 breaks IDEs static analysis for imports. The dynamic imports work fine at runtime.

PyCharm

image

VSCode

image

Google Colab

Legacy import:

Screenshot 2024-06-21 at 11 00 52

**New Import from EF file: **
Screenshot 2024-06-21 at 11 00 28

Versions

Chroma@main

Relevant log output

No response
@tazarov tazarov added the bug Something isn't working label Jun 21, 2024
@tazarov tazarov changed the title [Bug]: New EF refactor breaks static analysis of imports for IDEs [Bug][DX]: New EF refactor breaks static analysis of imports for IDEs Jun 21, 2024
@tazarov
Copy link
Contributor Author

tazarov commented Jun 21, 2024

cc @atroyn and @nablabits

@atroyn
Copy link
Contributor

atroyn commented Jun 21, 2024 •
edited
Loading

This is probably happening because of the way we do dynamic imports. I agree it's a bad user experience. @tazarov if you can take some time to see how this can be improved while retaining dynamic importing, that would be helpful. Maybe we need to populate __all__ ?

@jeffchuber
Copy link
Contributor

@tazarov lmk if you can take a look! :)

@tazarov
Copy link
Contributor Author

tazarov commented Jun 24, 2024

I'll have the PR up shortly.

@tazarov tazarov linked a pull request Jun 24, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH]: Static re-export of existing EFs for IDE static analysis chroma-core/chroma
3 participants
@jeffchuber @tazarov @atroyn