(#3451) Use availablePackages in GetPackageDependencies #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the dependency handling of packages to use availablePackages when a package from the same source satisfies the dependency. This improves packages that have dependencies with many versions available, and allows less data being requested from servers in the case we have already have available packages from the source. Without this fix, the installation will be delayed with repeated resolution of the same package dependencies.
| { | ||
| IEnumerable<SourcePackageDependencyInfo> dependencyInfos = Array.Empty<SourcePackageDependencyInfo>(); | ||
| var dependencyInfoResource = resource.DependencyInfoResource; |
There was a problem hiding this comment.
DependencyInfoResources() has a not null check, given that you are accessing the dependency info resource directly here, make sure to do check to make sure it is not null.
There was a problem hiding this comment.
I've updated it to match the null check in the GetPackagesDependencies overload that takes a PackageIdentity (matches lines 378-382).
Null resources should not be used when resolving packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This updates the dependency handling of packages to use availablePackages when a package from the same source satisfies the dependency. This improves packages that have dependencies with many versions available, and allows less data being requested from servers in the case we have already have available packages from the source.
Without this fix, the installation will be delayed with repeated resolution of the same package dependencies.
Motivation and Context
Installation of packages with many dependent versions available without reducing repeat calls to ResolvePackages
Testing
choco upgrade package-a --yes --source <path-to-demo-projects>Repeat test with delivered chocolatey 2.3 and see that the install takes much longer.
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3451