Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Combobox disabled states are too lazily evaluated #1620

Closed
Jonas-C opened this issue Jun 26, 2024 · 0 comments 路 Fixed by #1625
Closed

Bug: Combobox disabled states are too lazily evaluated #1620

Jonas-C opened this issue Jun 26, 2024 · 0 comments 路 Fixed by #1625
Labels
bug Something isn't working

Comments

@Jonas-C
Copy link
Contributor

Jonas-C commented Jun 26, 2024

馃悰 Bug report

When filtered out items reappear in a combobox list, they only regain their disabled value once they've been interactived with.

馃挜 Steps to reproduce

  1. Click the combobox and type z
  2. Backspace to remove the z. The disabled state of Benin is now gone.

馃捇 Link to reproduction

https://codesandbox.io/p/sandbox/youthful-nightingale-mtfjfc?file=%2Fsrc%2Fstyles.css%3A14%2C26&layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clxvvabhh00062e69hn763il6%2522%252C%2522sizes%2522%253A%255B100%252C0%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clxvvabhh00022e69gy6k1isu%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clxvvabhh00032e694vusybag%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clxvvabhh00052e69xz8uti3y%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B50%252C50%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clxvvabhh00022e69gy6k1isu%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clxvvabhh00012e692omaxqwj%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fsrc%252Findex.tsx%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522clxvvi6nd00022e69bw49zd6w%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A14%252C%2522startColumn%2522%253A26%252C%2522endLineNumber%2522%253A14%252C%2522endColumn%2522%253A26%257D%255D%252C%2522filepath%2522%253A%2522%252Fsrc%252Fstyles.css%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522id%2522%253A%2522clxvvabhh00022e69gy6k1isu%2522%252C%2522activeTabId%2522%253A%2522clxvvi6nd00022e69bw49zd6w%2522%257D%252C%2522clxvvabhh00052e69xz8uti3y%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clxvvabhh00042e69az4dh9hd%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522UNASSIGNED_PORT%2522%252C%2522port%2522%253A0%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522id%2522%253A%2522clxvvabhh00052e69xz8uti3y%2522%252C%2522activeTabId%2522%253A%2522clxvvabhh00042e69az4dh9hd%2522%257D%252C%2522clxvvabhh00032e694vusybag%2522%253A%257B%2522tabs%2522%253A%255B%255D%252C%2522id%2522%253A%2522clxvvabhh00032e694vusybag%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Afalse%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D

馃 Expected behavior

Items should always have their correct states.

馃實 System information

Software Version(s)
Zag Version 0.58.2
Browser Firefox
Operating System MacOS
@segunadebayo segunadebayo added the bug Something isn't working label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants