You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although the names v1 and q1 refer to the same register, their interpretations are different (i.e., q1 as a single 128-bit quantity while v0 as a vector of something).
The text was updated successfully, but these errors were encountered:
Looked into it and wouldn't restore the version of v5.
As you already said, the v1 and q1 refer to the same register. Due to the Vector Arrangement Specifier and the Vector index, the offset in the register can be determined definitely. So semantically we shouldn't have a problem.
Now, simply printing v1 instead of q1 is not easily possible, because the API doesn't allow it. The cs_reg_name() function only takes register identifiers. And v1 and q1 share the same identifier: AArch64_REG_Q1. Hence it cannot decide which name to print.
Now, we could duplicate the register identifiers for Vn registers (as in v5), but this complicates usage of the API again. Because users have to check for AArch64_REG_V1 and AArch64_REG_Q1 to check, if they deal with the same register.
Second alternative is some complicated handling of this exception in cs_reg_name(). But I don't think this is worth it, for such a small syntactical difference, which is semantically correct. (Also I am not sure it would actually work).
I added a flag in aarch64_op which indicates if the register is a Vn register.
And for cstool I simply added the (vreg) postfix.
For instruction
mov w20, v1.s[0]
(0x0e043c34),I get the correct information with the version 5.0.0:
Whereas, with the next branch, I get
q1
instead ofv1
for the second operand:Although the names
v1
andq1
refer to the same register, their interpretations are different (i.e.,q1
as a single 128-bit quantity whilev0
as a vector of something).The text was updated successfully, but these errors were encountered: