Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples-for-discussion folder and move DMH repo instead #113

Open
Tracked by #105
sujaypatil96 opened this issue Sep 16, 2021 · 4 comments · May be fixed by #143
Open
Tracked by #105

Remove examples-for-discussion folder and move DMH repo instead #113

sujaypatil96 opened this issue Sep 16, 2021 · 4 comments · May be fixed by #143

Comments

@sujaypatil96
Copy link
Contributor

No description provided.

@gaurav
Copy link
Collaborator

gaurav commented Sep 16, 2021

This folder was created during the CCDH Pilot to quickly have somewhere to have a discussion about codeable concepts and enums. It looks like DMH is moving some of these discussions into their own repository (https://github.com/cancerDHC/data-model-harmonization/tree/master/data-examples/f2f-2021-09-data-examples/mapping_provenance_proposals), so maybe this is no longer needed? On the other hand, I feel like this ought to be the right place to have these discussions.

One alternate idea that I like is to have a general examples/ folder that contains a variety of example CRDCH instance data (as covered by #59), which we can then test automatically. If we do something like that, we'll have to make sure that the testable example data is clearly separated from the "potential" example data that describes features we are considering adding later.

Let's discuss this with the Data Model Harmonization team sometime in October.

@gaurav
Copy link
Collaborator

gaurav commented Oct 7, 2021

@bfurner @mbrush Would it be okay if we moved the examples-for-discussion folder into the https://github.com/cancerDHC/data-model-harmonization repository? If we had more design documents in the ccdhmodel repo, I think it would make sense to leave it here, but since we don't have any others, I think it would be cleaner to move this elsewhere. What do you both think?

@gaurav
Copy link
Collaborator

gaurav commented Oct 14, 2021

We're citing this folder in our Q3 2021 quarterly report (as https://github.com/cancerDHC/ccdhmodel/tree/main/examples-for-discussion), so:

  1. Let's leave this where it is for now.
  2. If we do decide to move it to another repository, let's leave a README file in this folder so we can point people to the new location of these files, at least for a year or so.

@bfurner
Copy link
Contributor

bfurner commented Oct 18, 2021

@gaurav i am fine with moving this to https://github.com/cancerDHC/data-model-harmonization and following approach 2 above with the README. would you be able to handle this move?

@sujaypatil96 sujaypatil96 linked a pull request Oct 19, 2021 that will close this issue
@sujaypatil96 sujaypatil96 linked a pull request Oct 19, 2021 that will close this issue
@gaurav gaurav changed the title Remove examples-for-discussion folder and create a separate repo for it. Remove examples-for-discussion folder and move DMH repo instead Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants