Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of compression field causes stale size being displayed in UI #1750

Open
henry-spanka opened this issue Jul 11, 2023 · 3 comments · May be fixed by #1751
Open

Removal of compression field causes stale size being displayed in UI #1750

henry-spanka opened this issue Jul 11, 2023 · 3 comments · May be fixed by #1751
Labels
status:planning For large features, plan it out before implementation

Comments

@henry-spanka
Copy link
Contributor

henry-spanka commented Jul 11, 2023 •
edited
Loading

Description

unique_csize field was removed in commit f9d1260
I didn't find any reasoning behind this decision and would therefore like someone to clarify.

The Compressed Size field was not removed from the repository view and this causes the following:

  • For old repositories before this change, the Compressed Size will show an outdated size of the repository before Vorta was upgraded past this commit and is never updated.
    Screenshot 2023-07-11 at 18 39 55

  • For new repositories after this change, the Compressed Size displays N/A.
    Screenshot 2023-07-11 at 18 40 39
    Additionally hovering over N/A (tooltip) displays "Try refreshing the metadata of any archive" which is misleading as the functionality was removed.

Proposed Change

I'd either like to see the Compressed Size field being completely removed or add it again.

Environment

  • OS: Mac
  • Vorta version: 0.8.11
  • Installed from: Homebrew
  • Borg version: 1.2.4
@real-yfprojects
Copy link
Collaborator

Iirc the compressed size was removed in borg v2. That's why we removed the code handling it entirely. However I agree that this isn't the optimal solution.

@real-yfprojects real-yfprojects added the status:planning For large features, plan it out before implementation label Jul 11, 2023
@henry-spanka
Copy link
Contributor Author

Yes you are correct, seems like it.
Implementing version checking for v1 or v2 should be trivial. Display Compressed Size in v1 and hide it in v2. I can provide a PR for it if you think that would be a good solution.

@real-yfprojects
Copy link
Collaborator

Yes you are correct, seems like it.
Implementing version checking for v1 or v2 should be trivial. Display Compressed Size in v1 and hide it in v2. I can provide a PR for it if you think that would be a good solution.

Very much appreciated! You can use older commits as a reference.

@henry-spanka henry-spanka linked a pull request Jul 12, 2023 that will close this issue
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:planning For large features, plan it out before implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix repository compression size henry-spanka/vorta
2 participants
@henry-spanka @real-yfprojects