Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Importance of async? #9

Open
mahmoud opened this issue Mar 6, 2019 · 1 comment
Open

Importance of async? #9

mahmoud opened this issue Mar 6, 2019 · 1 comment

Comments

@mahmoud
Copy link

mahmoud commented Mar 6, 2019

Excellent work! Just wanted to mention, if straight-line performance is the goal, it may be worth testing a non-async version of the code. Most operations are going to be gated on the dictionary backing the application, so unless idle connections are part of the benchmark, the async component might be introducing more overhead than strictly necessary. What do you think?

@boramalper
Copy link
Owner

Hmm, I could not find a benchmark back then that compares uvloop backed asyncio protocol to non-async versions, though the "traditional" way comes with its own implementation complexity too so I wouldn't consider it unless there is a significant performance gain to be made.

Let me know if you find any such benchmarks and I am happy to try alternative approaches! =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants