We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events without hosts associated with them, such as FILESYSTEM, should probably not have their scope distance incremented.
FILESYSTEM
The text was updated successfully, but these errors were encountered:
Just looking into this, seems like I can add a if to the BaseEvent class that can satisfy this requirement
BaseEvent
if self.host: if self._scope_distance_increment_same_host or not hosts_are_same: new_scope_distance += 1 self.scope_distance = new_scope_distance
Not sure if its as simple as this or if theres more areas that I'm overlooking
Sorry, something went wrong.
Looks good.
The majority of the work will be in fixing the tests and making sure everything works as intended.
Hey @domwhewell-sage, are you working on this one? If not, I can take it.
Hey, I started with the if statement but the tests were returning some strange results (i.e. distance-0 for events that shouldn't be)
So it might make more sense to cast your expert eye over it @TheTechromancer
Roger I'll take a look
TheTechromancer
No branches or pull requests
Events without hosts associated with them, such as
FILESYSTEM
, should probably not have their scope distance incremented.The text was updated successfully, but these errors were encountered: