Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3D rendering release notes #1411

Merged
merged 30 commits into from
Jun 26, 2024
Merged

Add 3D rendering release notes #1411

merged 30 commits into from
Jun 26, 2024

Conversation

alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Jun 16, 2024 •
edited
Loading

This PR aims to tackle all of the assorted outstanding 3D rendering patch notes all at once. These are almost entirely features by @pcwalton, but there's one from @aevyrie as well :)

Like always, I'm still relatively novice at rendering, so corrections are extremely welcome.

To Do

I've opened this PR very early in order to more easily track work that needs to be done.

  • grab PR descriptions for the required PRs to work off of
  • finish drafting the initial notes
  • edit titles of each section
  • add images
  • make sure that every post links to an example if possible
  • self-editing pass

Linked PRs

@alice-i-cecile alice-i-cecile marked this pull request as draft June 16, 2024 19:09
@aevyrie
Copy link
Member

aevyrie commented Jun 17, 2024

I'll try to take a look at this tonight!

@alice-i-cecile
Copy link
Member Author

Awesome :) It's still not done, but feedback on the first few PRs (no > marks) would be very welcome.

@alice-i-cecile alice-i-cecile mentioned this pull request Jun 19, 2024
Closed
@alice-i-cecile
Copy link
Member Author

We need to redo / improve the screenshots for this before merging.

@alice-i-cecile alice-i-cecile mentioned this pull request Jun 20, 2024
Merged
@kristoff3r kristoff3r mentioned this pull request Jun 21, 2024
Merged
@alice-i-cecile alice-i-cecile added this to the Release v0.14 milestone Jun 21, 2024
@alice-i-cecile alice-i-cecile marked this pull request as draft June 25, 2024 14:25
@alice-i-cecile alice-i-cecile marked this pull request as ready for review June 26, 2024 01:24
IceSentry
IceSentry approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an image.png that should be removed. I also added a few nits, but nothing is a blocker so LGTM

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 26, 2024
Merged via the queue into bevyengine:main with commit 4b6c9aa Jun 26, 2024
10 checks passed
@alice-i-cecile alice-i-cecile deleted the pcwalton-rocks branch June 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton pcwalton left review comments

@superdump superdump superdump left review comments

@aevyrie aevyrie aevyrie left review comments

@BD103 BD103 BD103 left review comments

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Release-Notes C-Content S-Needs-Review
Projects
None yet
Milestone
Release v0.14
Development

Successfully merging this pull request may close these issues.

Write release notes for PR #13450: Implement PBR anisotropy per KHR_materials_anisotropy. Write release notes for PR #13057: Implement volumetric fog and volumetric lighting, also known as light shafts or god rays. Write release notes for PR #13009: Implement fast depth of field as a postprocessing effect. Write release notes for PR #9924: Per-Object Motion Blur Write release notes for PR #12910: Implement percentage-closer filtering (PCF) for point lights.
Write release notes for PR #13121: Implement filmic color grading. Write release notes for PR #12916: Implement visibility ranges, also known as hierarchical levels of detail (HLODs). Write release notes for PR #13423: Implement subpixel morphological antialiasing, or SMAA.
6 participants
@alice-i-cecile @aevyrie @pcwalton @superdump @IceSentry @BD103