ULC: build the universal linux client also for rpm based OS. #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstorz
force-pushed
the
dev/pstorz/master/ulc-for-rpm
branch
from
33d2195
to
678c4fa
Compare
pstorz
force-pushed
the
dev/pstorz/master/ulc-for-rpm
branch
from
930aff9
to
c77727c
Compare
arogge
reviewed
Jun 3, 2024
.matrix.yml
Outdated
| IMAGE: "rhel8" | ||
| BUILD_SCRIPT: CD/rpm/build-ulc.sh | ||
| FINISH_SCRIPT: CD/rpm/finish-ulc.sh | ||
| CUSTOM_TEST_IMAGES: [ "rhel8", "rhel9" ] |
There was a problem hiding this comment.
Suggested change
| CUSTOM_TEST_IMAGES: [ "rhel8", "rhel9" ] | |
| CUSTOM_TEST_IMAGES: [ Rocky-8, Fedora-36, Fedora-37, SLE-15_sp6 ] |
pstorz
force-pushed
the
dev/pstorz/master/ulc-for-rpm
branch
2 times, most recently
from
7cfb674
to
aa56690
Compare
arogge
requested changes
Jun 20, 2024
Comment on lines
165
to
169
| %if 0%{?suse_version} | ||
| Requires(pre): shadow | ||
| %else | ||
| Requires(pre): shadow-utils | ||
| %endif |
There was a problem hiding this comment.
we cannot have distro-dependant Requires in the ULC package
Comment on lines
176
to
181
| %if 0%{?suse_version} | ||
| Requires(pre): shadow | ||
| %else | ||
| Requires(pre): glibc-common | ||
| Requires(pre): shadow-utils | ||
| %endif |
There was a problem hiding this comment.
same here, dependencies cannot depend on the distro
There was a problem hiding this comment.
I think we can remove the requirement on glibc-common and replace the shadow/shadow-utils requirement with
Requires: /usr/sbin/useradd
Requires: /usr/sbin/groupadd
There was a problem hiding this comment.
maybe it makes sense to replace the other package dependencies (i.e. sed, gawk, grep, etc.) by program dependencies, too
pstorz
force-pushed
the
dev/pstorz/master/ulc-for-rpm
branch
from
fe0adb5
to
3c96a1b
Compare
pstorz
force-pushed
the
dev/pstorz/master/ulc-for-rpm
branch
from
3c96a1b
to
2ae6e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests